Conversation
robcsegal
requested review from
albertsola,
alephsur,
d3rky,
jentyk,
ruben-sebrango and
svazquezco
as code owners
robcsegal
force-pushed
the
MPT-14864-add-e-2-e-tests-for-accounts-endpoints-for-crud-and-state-operations
branch
from
747d9e3 to
337cc40
Compare
d3rky
approved these changes
Nov 12, 2025
albertsola
reviewed
Nov 12, 2025
Comment on lines
+54
to
+62
| async def test_update_account_invalid_data( | ||
| async_mpt_ops, account, async_created_account, account_icon | ||
| ): | ||
| updated_data = account(name="") | ||
|
|
||
| with pytest.raises(MPTAPIError, match=r"400 Bad Request"): | ||
| await async_mpt_ops.accounts.accounts.update( | ||
| async_created_account.id, updated_data, logo=account_icon | ||
| ) |
albertsola
approved these changes
Nov 12, 2025
Contributor
|
Are you updating the seeder as part of the E2E tests update? |
robcsegal
force-pushed
the
MPT-14864-add-e-2-e-tests-for-accounts-endpoints-for-crud-and-state-operations
branch
from
337cc40 to
0ca4012
Compare
Contributor
Author
I'm doing seeding separately. |
|
robcsegal
deleted the
MPT-14864-add-e-2-e-tests-for-accounts-endpoints-for-crud-and-state-operations
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Accounts accounts e2e CRUD and state endpoints tests
https://softwareone.atlassian.net/browse/MPT-14864